Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16785 )
Change subject: [thirdparty] Upgrade CMake to 3.19 ...................................................................... Patch Set 1: (4 comments) Looks reasonable to me, but I need to confirm it works with XCode 10 on my HighSierra laptop. http://gerrit.cloudera.org:8080/#/c/16785/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16785/1//COMMIT_MSG@10 PS1, Line 10: will with http://gerrit.cloudera.org:8080/#/c/16785/1//COMMIT_MSG@12 PS1, Line 12: includeds includes http://gerrit.cloudera.org:8080/#/c/16785/1//COMMIT_MSG@14 PS1, Line 14: occured occurred http://gerrit.cloudera.org:8080/#/c/16785/1/src/kudu/codegen/CMakeLists.txt File src/kudu/codegen/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/16785/1/src/kudu/codegen/CMakeLists.txt@100 PS1, Line 100: --sysroot="${CMAKE_OSX_SYSROOT}") > It is a CMake variable that CMake will set if you don't. https://cmake.org/ Yup, it's in CMake 3.11 already, so it should be safe (we require cmake of 3.11.2 minimum version in the top-level cmakefile): https://cmake.org/cmake/help/v3.11/variable/CMAKE_OSX_SYSROOT.html -- To view, visit http://gerrit.cloudera.org:8080/16785 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I125448a3057d0c9da8c82f7e29683ef7844b0aa8 Gerrit-Change-Number: 16785 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 25 Nov 2020 22:54:59 +0000 Gerrit-HasComments: Yes
