Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16794 )
Change subject: client: allow tablet ID lookups from the MetaCache ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/meta_cache.h@427 PS3, Line 427: LookupTabletById nit: add a comment? http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/meta_cache.cc@92 PS3, Line 92: client_tablet_locations_by_id_ttl_ms Sorry, not directly related to your change, but do you think such flag makes sense for cache by key as well? http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/meta_cache.cc@662 PS3, Line 662: Status new_status = status; : if (RetryOrReconnectIfNecessary(&new_status)) { : ignore_result(delete_me.release()); : return; : } : // Check for more application errors. : // Note: RetryOrReconnectIfNecessary only checked for generic application : // errors. This check is specific to LookupRpcById. : if (new_status.ok() && resp_.has_error()) { : new_status = StatusFromPB(resp_.error().status()); : if (new_status.IsServiceUnavailable()) { : // One or more of the tablets is not running. Retry after some time. : mutable_retrier()->DelayedRetry(this, new_status); : ignore_result(delete_me.release()); : return; : } : } This seems dup with LookupRpc::SendRpcCb, do you think it is worth to generalize the common code? -- To view, visit http://gerrit.cloudera.org:8080/16794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2333add5c3ab8403c48e69d29c90f3aec0914b6 Gerrit-Change-Number: 16794 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 02 Dec 2020 23:37:06 +0000 Gerrit-HasComments: Yes
