Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16794 )
Change subject: client: allow tablet ID lookups from the MetaCache ...................................................................... Patch Set 4: Code-Review+2 (4 comments) Looks good to me! http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/client-test.cc@2270 PS3, Line 2270: FLAGS_client_tablet_locations_by_id_ttl_ms = 25; > I assume so because this is the value used in TestMetaCacheExpiry. SGTM, thank you for the clarification! http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/client-test.cc@2287 PS3, Line 2287: ASSERT_TRUE(meta_cache->LookupEntryByIdFastPath(tablet_id, &entry)) > Done thanks! http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/meta_cache.cc@92 PS3, Line 92: client_tablet_locations_by_id_ttl_ms > The key-based TTL is defined on the master, and sent over in the response t I see: it makes sense. I missed the fact that the system txn client is a part of Kudu's server side -- in this case I guess it's better to keep this flag as is. http://gerrit.cloudera.org:8080/#/c/16794/3/src/kudu/client/meta_cache.cc@981 PS3, Line 981: else { > 'remote' is a scoped_ptr. I can make that explicit above instead of using a whoops, indeed -- I overlooked that fact :) -- To view, visit http://gerrit.cloudera.org:8080/16794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2333add5c3ab8403c48e69d29c90f3aec0914b6 Gerrit-Change-Number: 16794 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 07 Dec 2020 06:03:50 +0000 Gerrit-HasComments: Yes
