Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16854 )
Change subject: [build] Add the option to use the protoc from thirdparty in the java build ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/dependencies.gradle File java/gradle/dependencies.gradle: http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/dependencies.gradle@70 PS3, Line 70: warn nit: same here? Why not info? http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/protobuf.gradle File java/gradle/protobuf.gradle: http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/protobuf.gradle@29 PS3, Line 29: warn nit: why is this a warning? If a user's opted into it, isn't it expected behavior? Are there downsides to using thirdparty's protoc? -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 19:22:09 +0000 Gerrit-HasComments: Yes
