Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16854 )
Change subject: [build] Add the option to use the protoc from thirdparty in the java build ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16854/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16854/3//COMMIT_MSG@12 PS3, Line 12: : Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f : ex: `gradle assemble -PuseKuduProtoc` > nit: swap lines Done http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/dependencies.gradle File java/gradle/dependencies.gradle: http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/dependencies.gradle@70 PS3, Line 70: warn > nit: same here? Why not info? Only the warn level shows up by default and we want to print/show it because it's "unusual". http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/protobuf.gradle File java/gradle/protobuf.gradle: http://gerrit.cloudera.org:8080/#/c/16854/3/java/gradle/protobuf.gradle@29 PS3, Line 29: warn > nit: why is this a warning? If a user's opted into it, isn't it expected be Only the warn level shows up by default and we want to print/show it because it's "unusual". The downside might be non reproducible builds depending on the state of thirdparty. -- To view, visit http://gerrit.cloudera.org:8080/16854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64bdf94c222c971b4900213d58f25c50c860ec9f Gerrit-Change-Number: 16854 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 19:38:20 +0000 Gerrit-HasComments: Yes
