Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16860 )
Change subject: KUDU-2612: allow participant ops to detect idempotent calls ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/16860/2/src/kudu/tablet/txn_participant.h File src/kudu/tablet/txn_participant.h: http://gerrit.cloudera.org:8080/#/c/16860/2/src/kudu/tablet/txn_participant.h@a78 PS2, Line 78: : : : : : : : : : > nit: why not to move this out of the class once TxnState enum is no longer Done http://gerrit.cloudera.org:8080/#/c/16860/2/src/kudu/tablet/txn_participant.h@47 PS2, Line 47: l state; > nit: Is this just to avoid casting to an integer while printing? Otherwise Done http://gerrit.cloudera.org:8080/#/c/16860/2/src/kudu/tablet/txn_participant.h@243 PS2, Line 243: er::T > nit: drop ? Done http://gerrit.cloudera.org:8080/#/c/16860/2/src/kudu/tablet/txn_participant.h@249 PS2, Line 249: if (expected_metadata_s > nit: might it be simpler to introduce an extra kNoState entry for TxnState Done -- To view, visit http://gerrit.cloudera.org:8080/16860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If82d3d1aad6737dd4f9f234b122b8c15d65a6604 Gerrit-Change-Number: 16860 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 12 Dec 2020 04:34:24 +0000 Gerrit-HasComments: Yes
