Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16860 )
Change subject: KUDU-2612: allow participant ops to detect idempotent calls ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16860/4/src/kudu/tablet/txn_participant.h File src/kudu/tablet/txn_participant.h: http://gerrit.cloudera.org:8080/#/c/16860/4/src/kudu/tablet/txn_participant.h@46 PS4, Line 46: int8_t nit: it would be nice to add a comment why this is necessary; is this just to have exact size because this will be persisted as part of metadata? http://gerrit.cloudera.org:8080/#/c/16860/4/src/kudu/tablet/txn_participant.h@251 PS4, Line 251: expected_metadata_state nit: maybe, for clarity use expected_metadata_state != kNone ? -- To view, visit http://gerrit.cloudera.org:8080/16860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If82d3d1aad6737dd4f9f234b122b8c15d65a6604 Gerrit-Change-Number: 16860 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 12 Dec 2020 05:15:53 +0000 Gerrit-HasComments: Yes
