Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16866 )
Change subject: [rpc] weak_ptr for Messenger in RpcRetrier ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16866/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16866/1//COMMIT_MSG@12 PS1, Line 12: retries > For my own understanding, this would retry until it eventually timed out, r In general, yes. However, while doing so, it might try to access some fields from objects which are not longer there if RPC contains raw pointers and references to those. That happened in http://dist-test.cloudera.org/job?job_id=jenkins-slave.1607649291.2575691 before I moved txn_multi_manager to be a field member of the RPC itself. -- To view, visit http://gerrit.cloudera.org:8080/16866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I399eef35341c4c9e90d91b1e461302a985d8f283 Gerrit-Change-Number: 16866 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 12 Dec 2020 04:54:11 +0000 Gerrit-HasComments: Yes
