Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16866 )
Change subject: [rpc] weak_ptr for Messenger in RpcRetrier ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16866/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16866/1//COMMIT_MSG@12 PS1, Line 12: retries > Sorry, a bit confused here, is the dist test you linked for this patch? If The dist-test run at http://dist-test.cloudera.org/job?job_id=jenkins-slave.1607649291.2575691 was not produced by/with this patch. That one is referring to a run after e75aad09a8dbe295a11cc2042903b74faf72623e but before 49c922b5cc3e5d7ee885c6f355eec973a5334441. The latter fixed the issue I was referring to. This patch is more about dropping the reference to Messenger once the top-level object that created it is out of scope, so there would be needless retries if some RPC are still in-flight. Basically, that's about freeing unneeded resources earlier. -- To view, visit http://gerrit.cloudera.org:8080/16866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I399eef35341c4c9e90d91b1e461302a985d8f283 Gerrit-Change-Number: 16866 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Dec 2020 20:04:21 +0000 Gerrit-HasComments: Yes
