Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15851 )
Change subject: [benchmarks] Add single node YCSB testing scripts ...................................................................... Patch Set 3: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/15851/3/src/kudu/benchmarks/ycsb/README.adoc File src/kudu/benchmarks/ycsb/README.adoc: http://gerrit.cloudera.org:8080/#/c/15851/3/src/kudu/benchmarks/ycsb/README.adoc@17 PS3, Line 17: = Kudu YCSB Experiments nit: would be nice to put a simple sample incantation, any assumptions w.r.t PWD, build directories, etc May also be worth adding a warning like, don't run this if there are existing Kudu daemons, because these scripts will probably kill them. http://gerrit.cloudera.org:8080/#/c/15851/3/src/kudu/benchmarks/ycsb/columns-setup.yaml File src/kudu/benchmarks/ycsb/columns-setup.yaml: http://gerrit.cloudera.org:8080/#/c/15851/3/src/kudu/benchmarks/ycsb/columns-setup.yaml@88 PS3, Line 88: uniform Not advocating change, but this doesn't matter, since in both of our workloads this is manually set, right? http://gerrit.cloudera.org:8080/#/c/15851/3/src/kudu/benchmarks/ycsb/columns-setup.yaml@119 PS3, Line 119: 1-workload: nit: haven't made my way through the rest of the patch yet, but are the numeric prefixes useful here? Should we just leave the dimensions as 'workload', etc.? http://gerrit.cloudera.org:8080/#/c/15851/3/src/kudu/benchmarks/ycsb/columns-setup.yaml@135 PS3, Line 135: size nit: maybe 'rowsize_bytes' or somesuch? http://gerrit.cloudera.org:8080/#/c/15851/3/src/kudu/benchmarks/ycsb/run_experiments.py File src/kudu/benchmarks/ycsb/run_experiments.py: http://gerrit.cloudera.org:8080/#/c/15851/3/src/kudu/benchmarks/ycsb/run_experiments.py@152 PS3, Line 152: userable usertable? -- To view, visit http://gerrit.cloudera.org:8080/15851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib022e654e6c9367fff8fd38197d7e31abaa0e874 Gerrit-Change-Number: 15851 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 15 Dec 2020 00:18:42 +0000 Gerrit-HasComments: Yes
