Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15851 )
Change subject: [benchmarks] Add single node YCSB testing scripts ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/15851/3/src/kudu/benchmarks/ycsb/README.adoc File src/kudu/benchmarks/ycsb/README.adoc: http://gerrit.cloudera.org:8080/#/c/15851/3/src/kudu/benchmarks/ycsb/README.adoc@17 PS3, Line 17: = Kudu YCSB Experiments > nit: would be nice to put a simple sample incantation, any assumptions w.r. +1 : would be great to have a working example with in-line comments. Or one of the scripts already contain that? http://gerrit.cloudera.org:8080/#/c/15851/3/src/kudu/benchmarks/ycsb/columns-setup.yaml File src/kudu/benchmarks/ycsb/columns-setup.yaml: PS3: nit: is Apache license header needed here? http://gerrit.cloudera.org:8080/#/c/15851/3/src/kudu/benchmarks/ycsb/parse_ycsb_log.py File src/kudu/benchmarks/ycsb/parse_ycsb_log.py: PS3: nit: is Apache license header needed here? http://gerrit.cloudera.org:8080/#/c/15851/3/src/kudu/benchmarks/ycsb/requirements.txt File src/kudu/benchmarks/ycsb/requirements.txt: PS3: nit: is Apache license header needed here or add this file into the RAT exceptions list? -- To view, visit http://gerrit.cloudera.org:8080/15851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib022e654e6c9367fff8fd38197d7e31abaa0e874 Gerrit-Change-Number: 15851 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 15 Dec 2020 01:20:46 +0000 Gerrit-HasComments: Yes
