Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16875 )
Change subject: client: retry id-based lookups if there is no leader ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16875/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/16875/2/src/kudu/client/client-test.cc@2490 PS2, Line 2490: for (auto& r : replicas) { nit: I guess it's semi-obvious, but it would be great if the same for() cycle was there to verify that there isn't a leader among the replicas after calling MarkTServerAsFollower() :) Maybe, this piece of code might be separated into a lambda and reused for such a purpose. http://gerrit.cloudera.org:8080/#/c/16875/2/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/16875/2/src/kudu/client/meta_cache.cc@1234 PS2, Line 1234: entry.tablet()->HasLeader() Good catch! Indeed, this piece seemed to be missing if comparing with MetaCache::DoFastPathLookup() -- To view, visit http://gerrit.cloudera.org:8080/16875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If311f7e94a4fc2efa067476a4cef9ef5b378d981 Gerrit-Change-Number: 16875 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 15 Dec 2020 02:40:17 +0000 Gerrit-HasComments: Yes
