Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16875 )
Change subject: client: retry id-based lookups if there is no leader ...................................................................... client: retry id-based lookups if there is no leader In testing out a later patch, I stumbled on the fact that we may end up never retrying a tablet lookup in cases where all cached replicas are marked as followers. The correct behavior is to attempt another lookup in hopes that the master has more up-to-date information about leadership than the client. This is only an issue with the new id-based MetaCache lookups. This patch extends the id-based path with logic that was already in the key-based lookup path that prevented this. Along the way, I did some renaming for clarity. Change-Id: If311f7e94a4fc2efa067476a4cef9ef5b378d981 Reviewed-on: http://gerrit.cloudera.org:8080/16875 Tested-by: Andrew Wong <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/client/client-test.cc M src/kudu/client/client.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h 4 files changed, 52 insertions(+), 9 deletions(-) Approvals: Andrew Wong: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If311f7e94a4fc2efa067476a4cef9ef5b378d981 Gerrit-Change-Number: 16875 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
