Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16879 )
Change subject: KUDU-2612: add RPC to send participant ops ...................................................................... Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/client/meta_cache.cc@505 PS1, Line 505: // TODO: When we support tablet splits, we should let the lookup shift > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/integration-tests/txn_participant-itest.cc File src/kudu/integration-tests/txn_participant-itest.cc: http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/integration-tests/txn_participant-itest.cc@99 PS1, Line 99: using kudu::tablet::TabletStatePB; > warning: using decl 'TabletStatePB' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/integration-tests/txn_participant-itest.cc@100 PS1, Line 100: using kudu::tablet::Txn; > warning: using decl 'Txn' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/tablet/txn_participant-test-util.h File src/kudu/tablet/txn_participant-test-util.h: http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/tablet/txn_participant-test-util.h@38 PS1, Line 38: tserver::ParticipantOpPB MakeParticipantOp( > warning: function 'MakeParticipantOp' defined in a header file; function de Done http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/tablet/txn_participant-test-util.h@51 PS1, Line 51: std::unique_ptr<ParticipantOpState> NewParticipantOp( > warning: function 'NewParticipantOp' defined in a header file; function def Done http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/transactions/participant_rpc.cc File src/kudu/transactions/participant_rpc.cc: http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/transactions/participant_rpc.cc@39 PS1, Line 39: using kudu::client::internal::RemoteTablet; > warning: using decl 'RemoteTablet' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/transactions/participant_rpc.cc@41 PS1, Line 41: using kudu::client::KuduClient; > warning: using decl 'KuduClient' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/transactions/participant_rpc.cc@48 PS1, Line 48: using kudu::tserver::CoordinatorOpResultPB; > warning: using decl 'CoordinatorOpResultPB' is unused [misc-unused-using-de Done http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/transactions/txn_system_client.h File src/kudu/transactions/txn_system_client.h: http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/transactions/txn_system_client.h@139 PS1, Line 139: Status ParticipateInTransaction(const std::string& tablet_id, > warning: function 'kudu::transactions::TxnSystemClient::ParticipateInTransa Done http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/transactions/txn_system_client.h@161 PS1, Line 161: void ParticipateInTransactionAsync(const std::string& tablet_id, > warning: function 'kudu::transactions::TxnSystemClient::ParticipateInTransa Done http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/transactions/txn_system_client.cc File src/kudu/transactions/txn_system_client.cc: http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/transactions/txn_system_client.cc@315 PS1, Line 315: std::move(participant_op), > warning: std::move of the const variable 'participant_op' has no effect; re Done http://gerrit.cloudera.org:8080/#/c/16879/1/src/kudu/transactions/txn_system_client.cc@330 PS1, Line 330: std::move(cb), > warning: std::move of the const variable 'cb' has no effect; remove std::mo Done -- To view, visit http://gerrit.cloudera.org:8080/16879 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9ba09104761772f9aaffe582776ad34d8dbf57 Gerrit-Change-Number: 16879 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 15 Dec 2020 09:31:01 +0000 Gerrit-HasComments: Yes
