Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16879 )
Change subject: KUDU-2612: add RPC to send participant ops ...................................................................... Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16879/4/src/kudu/integration-tests/txn_participant-itest.cc File src/kudu/integration-tests/txn_participant-itest.cc: http://gerrit.cloudera.org:8080/#/c/16879/4/src/kudu/integration-tests/txn_participant-itest.cc@896 PS4, Line 896: o* leader_replica = replicas[kLeaderIdx]; > When the old leader rejoins the quorum, it will abort ops from previous ter Thank you for the clarification. I think this behavior sounds like a consistent one, at least at this point I don't see how it could lead to a trouble, so it looks good so far :) http://gerrit.cloudera.org:8080/#/c/16879/4/src/kudu/transactions/txn_system_client.cc File src/kudu/transactions/txn_system_client.cc: http://gerrit.cloudera.org:8080/#/c/16879/4/src/kudu/transactions/txn_system_client.cc@321 PS4, Line 321: ectly. > Alas, it seems like there still won't be a great way to pass a unique_ptr i OK, I'll take a closer look -- thank you for the link. It's educational. Maybe, I'll play with it a bit, but for now this looks good enough as it is. -- To view, visit http://gerrit.cloudera.org:8080/16879 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb9ba09104761772f9aaffe582776ad34d8dbf57 Gerrit-Change-Number: 16879 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 22 Dec 2020 19:26:43 +0000 Gerrit-HasComments: Yes
