Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16934 )
Change subject: WIP [util] fix another lock contention in MaintenanceManager ...................................................................... Patch Set 2: (2 comments) Nice find! http://gerrit.cloudera.org:8080/#/c/16934/2/src/kudu/util/maintenance_manager.h File src/kudu/util/maintenance_manager.h: http://gerrit.cloudera.org:8080/#/c/16934/2/src/kudu/util/maintenance_manager.h@384 PS2, Line 384: Mutex lock_; nit: maybe it's worth commenting that this lock should be used very sparingly, since it's taken when finding the best op? It seems like with this patch, the only usages is by the scheduler thread, when adding/removing ops, and dumping the MM page, which seem reasonable enough. http://gerrit.cloudera.org:8080/#/c/16934/2/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/16934/2/src/kudu/util/maintenance_manager.cc@366 PS2, Line 366: DecreaseOpCount(op); : op->cond_->Signal(); nit: maybe combine this into some DecreaseOpCountAndNotifyWaiters() or somesuch? -- To view, visit http://gerrit.cloudera.org:8080/16934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63b12dd3641ef655f8fcbbad8d8ac515d874c0fb Gerrit-Change-Number: 16934 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 08 Jan 2021 20:12:03 +0000 Gerrit-HasComments: Yes
