Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16934 )
Change subject: [util] fix another lock contention in MaintenanceManager ...................................................................... Patch Set 2: (2 comments) Thank you for the fast review! http://gerrit.cloudera.org:8080/#/c/16934/2/src/kudu/util/maintenance_manager.h File src/kudu/util/maintenance_manager.h: http://gerrit.cloudera.org:8080/#/c/16934/2/src/kudu/util/maintenance_manager.h@384 PS2, Line 384: Mutex lock_; > nit: maybe it's worth commenting that this lock should be used very sparing Sounds like a good idea to me. Done. http://gerrit.cloudera.org:8080/#/c/16934/2/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/16934/2/src/kudu/util/maintenance_manager.cc@366 PS2, Line 366: DecreaseOpCount(op); : op->cond_->Signal(); > nit: maybe combine this into some DecreaseOpCountAndNotifyWaiters() or some Done -- To view, visit http://gerrit.cloudera.org:8080/16934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63b12dd3641ef655f8fcbbad8d8ac515d874c0fb Gerrit-Change-Number: 16934 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 08 Jan 2021 21:15:17 +0000 Gerrit-HasComments: Yes
