Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16940 )
Change subject: [java] Add JAAS example to client API doc ...................................................................... Patch Set 1: (3 comments) Thanks for putting this change together! http://gerrit.cloudera.org:8080/#/c/16940/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/16940/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@201 PS1, Line 201: conntect nit: connect Alternatively, "Create the KuduClient" or somesuch? Or maybe copy the actual builder code from below? Might not be clear what "connect" means, since there's no public "connect" call. http://gerrit.cloudera.org:8080/#/c/16940/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@211 PS1, Line 211: my-ap nit: not related to this patch, but how about naming this 'app-user' or something so it's clear it's a user. Should be obvious from the UGI docs, but still probably worth clearer naming. Better yet, it'd be great if both of these examples used consistent user/principals. E.g. point the JAAS example to /path/to/app.keytab and use feasible example users/principals. http://gerrit.cloudera.org:8080/#/c/16940/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@220 PS1, Line 220: will also automatically : * start a thread to periodically re-login from the keytab. Is anything equivalent done for JAAS? Do JAAS users need to worry about doing this themselves? -- To view, visit http://gerrit.cloudera.org:8080/16940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7db5bf67727f7318272de7ea2156a33255a2dc8b Gerrit-Change-Number: 16940 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Jan 2021 01:49:07 +0000 Gerrit-HasComments: Yes
