Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16940 )
Change subject: [java] Add JAAS example to client API doc ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16940/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/16940/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@201 PS1, Line 201: uClient > I like the idea of showing the construction of the kudu client like below. Done http://gerrit.cloudera.org:8080/#/c/16940/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@211 PS1, Line 211: code > +1 Changed it to appuser, this way we can keep the line length within 80 which seems to be the convention here. http://gerrit.cloudera.org:8080/#/c/16940/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@220 PS1, Line 220: : * ); > Is anything equivalent done for JAAS? Do JAAS users need to worry about doi There's a note above about having to relogin manually. Added that it needs to be done periodically to make it clearer. -- To view, visit http://gerrit.cloudera.org:8080/16940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7db5bf67727f7318272de7ea2156a33255a2dc8b Gerrit-Change-Number: 16940 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Jan 2021 09:03:07 +0000 Gerrit-HasComments: Yes
