Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16937 )
Change subject: [util] extra test for MaintenanceManager ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16937/2/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/16937/2/src/kudu/util/maintenance_manager-test.cc@798 PS2, Line 798: ASSERT_EQ(1, manager_->metrics_.op_prepare_failed->value()); I may be missing something, but doesn't TestMaintenanceOp::Prepare() fail after the first run as well? http://gerrit.cloudera.org:8080/#/c/16937/2/src/kudu/util/maintenance_manager-test.cc@853 PS2, Line 853: AssertEventually([&] { : ASSERT_EQ(1, ops.front()->DurationHistogram()->TotalCount()); : }, MonoDelta::FromSeconds(60)); Given how long this takes to run, how about scheduling fewer ops instead? Would that detract from the test coverage? -- To view, visit http://gerrit.cloudera.org:8080/16937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9e71b213583c000d4809dcfc885c1d31b3bb9d5 Gerrit-Change-Number: 16937 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 13 Jan 2021 19:56:40 +0000 Gerrit-HasComments: Yes
