Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16937 )
Change subject: [util] extra test for MaintenanceManager ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16937/2/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/16937/2/src/kudu/util/maintenance_manager-test.cc@798 PS2, Line 798: ASSERT_EQ(1, manager_->metrics_.op_prepare_failed->value()); > I may be missing something, but doesn't TestMaintenanceOp::Prepare() fail a Nope, TestMaintenanceOp::Prepare() doesn't fail after the first run because it because non-runnable: the scheduler doesn't schedule such an operation for another run because the operation becomes non-runnable (see how set_runnable() is called in TestMaintenanceOp::UpdateStats()). http://gerrit.cloudera.org:8080/#/c/16937/2/src/kudu/util/maintenance_manager-test.cc@853 PS2, Line 853: AssertEventually([&] { : ASSERT_EQ(1, ops.front()->DurationHistogram()->TotalCount()); : }, MonoDelta::FromSeconds(60)); > Given how long this takes to run, how about scheduling fewer ops instead? W It may take that long only in case of rare conditions (e.g. scheduling anomalies). As of now, it takes about 2 seconds on my laptop and 6 seconds on my Linux build server. Various scheduling anomalies happen when running the test with --stress_cpu_threads=16 and higher values. -- To view, visit http://gerrit.cloudera.org:8080/16937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9e71b213583c000d4809dcfc885c1d31b3bb9d5 Gerrit-Change-Number: 16937 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 16 Jan 2021 17:27:28 +0000 Gerrit-HasComments: Yes
