Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16957 )
Change subject: [blog] Cross post Bloom filter predicate blog post ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md File _posts/2021-01-15-bloom-filter-predicate.md: http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md@16 PS1, Line 16: nit here and below: remove trailing spaces ? http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md@20 PS1, Line 20: CDP Runtime 7.1.5 If using these downstream product names and versions in an upstream blog, I guess it would be nice to add corresponding references just for a reader's convenience. Probably, a short note in the very beginning of the post that reflects the version mapping would be appropriate. After that, in the text of this post it might be possible to switch to the upstream version numbers. http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md@48 PS1, Line 48: 7.1.5 I guess for an upstream blog post it would make sense to switch to upstream version numbers. Or at least mention that's a version of the CDP product, not Impala's. http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md@66 PS1, Line 66: Ram nit: RAM / DRAM ? http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md@66 PS1, Line 66: nit: add a column to separate these two parts? http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md@66 PS1, Line 66: disks What sort of disks were they? SSD or HDD? -- To view, visit http://gerrit.cloudera.org:8080/16957 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I725c8cb4b10487db1d3d18046c3f9a48f0381923 Gerrit-Change-Number: 16957 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 18 Jan 2021 03:50:29 +0000 Gerrit-HasComments: Yes
