Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16957 )
Change subject: [blog] Cross post Bloom filter predicate blog post ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md File _posts/2021-01-15-bloom-filter-predicate.md: http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md@16 PS1, Line 16: > nit here and below: remove trailing spaces ? My bad, I somehow expected a newline may not translate to a single space with markdown files and hence left a trailing space. http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md@20 PS1, Line 20: CDP Runtime 7.1.5 > Perhaps just mapping the versions in the post to similar apache version in a > note at the top would be good enough (as opposed to here inline). That's a good idea. http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md@48 PS1, Line 48: 7.1.5 > I guess for an upstream blog post it would make sense to switch to upstream Added a separate version related above in the Notes section. http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md@66 PS1, Line 66: > nit: add a column to separate these two parts? Added worth 'with' instead. http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md@66 PS1, Line 66: Ram > nit: RAM / DRAM ? Done http://gerrit.cloudera.org:8080/#/c/16957/1/_posts/2021-01-15-bloom-filter-predicate.md@66 PS1, Line 66: disks > What sort of disks were they? SSD or HDD? Done -- To view, visit http://gerrit.cloudera.org:8080/16957 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I725c8cb4b10487db1d3d18046c3f9a48f0381923 Gerrit-Change-Number: 16957 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 20 Jan 2021 21:16:52 +0000 Gerrit-HasComments: Yes
