Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16929 )
Change subject: KUDU-2612 Java client transaction implementation ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16929/4/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java: http://gerrit.cloudera.org:8080/#/c/16929/4/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java@292 PS4, Line 292: final Transactions.TxnStatePB txnState = resp.txnState(); > Do we expose the transaction state publicly anywhere? It could be useful to No, the transaction state isn't exposed anywhere, and that's intentional. I'm not sure it makes sense to expose that beyond verifying that transaction commit phase has completed. It might even confuse the users of the API, I guess. What might be the purpose of exposing the implementation details of the two-phase commit protocol in the API? Do you have any particular use case in mind where it's important to know the state of a transaction beyond tracking the finalization phase of a transaction after initiating committing a transaction via KuduTransaction.commit(false) ? http://gerrit.cloudera.org:8080/#/c/16929/4/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java@466 PS4, Line 466: // TODO(adar): By scheduling even the first RPC via timer, the sequence of > Is this comment copied somewhere? Is it completely relevant here? Yes, this comment is copied. And yes, it's relevant here as in other places as well. -- To view, visit http://gerrit.cloudera.org:8080/16929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0236875e7264877c3f7a13da4a5a3da6423786b Gerrit-Change-Number: 16929 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Comment-Date: Thu, 21 Jan 2021 16:24:28 +0000 Gerrit-HasComments: Yes
