Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16929 )

Change subject: KUDU-2612 Java client transaction implementation
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16929/5/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java:

http://gerrit.cloudera.org:8080/#/c/16929/5/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java@271
PS5, Line 271: null
> Would it make sense to get the BeginTransactionRequest from doCommitTransac
Good catch!  Frankly, since there isn't a proper way to check it works, I guess 
it will be necessary to get back and verify  this code works once the commit 
orchestration is implemented.

So far I decided to add a test-only flag to commit a transaction just when 
processing BeginCommitTransaction request in TxnStatusManager.



--
To view, visit http://gerrit.cloudera.org:8080/16929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0236875e7264877c3f7a13da4a5a3da6423786b
Gerrit-Change-Number: 16929
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 26 Jan 2021 06:49:43 +0000
Gerrit-HasComments: Yes

Reply via email to