Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16968 )
Change subject: [build] Fix occasional Gradle build failures ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16968/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16968/1//COMMIT_MSG@10 PS1, Line 10: cryptic often Protobuf nit: maybe paste snippet of an exception? http://gerrit.cloudera.org:8080/#/c/16968/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/16968/1/CMakeLists.txt@127 PS1, Line 127: add_custom_command(OUTPUT ${CLIENT_JAR} : COMMAND ./gradlew :kudu-client:jar ${GRADLE_FLAGS} : WORKING_DIRECTORY "${JAVA_DIR}" : DEPENDS init_gradle) Just making sure I understand this correctly. The race is that kudu-subprocess and kudu-hms try to build kudu-proto, and in the off-chance these happen simultaneously, we hit an error. So the solution is to build kudu-client (and all its innards, including kudu-proto) before running either, ensuring the subprocess and hms builds don't collide. Is that right? Would it also have worked to have built just the protobuf module, rather than the entire client? -- To view, visit http://gerrit.cloudera.org:8080/16968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefa02e52a74f8a60c3029188995574ffdb0d3d5c Gerrit-Change-Number: 16968 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 25 Jan 2021 19:50:35 +0000 Gerrit-HasComments: Yes
