Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16968 )
Change subject: [build] Fix occasional Gradle build failures ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/16968/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16968/1//COMMIT_MSG@10 PS1, Line 10: cryptic often Protobuf > nit: maybe paste snippet of an exception? I have seen a few different exceptions occur depending on the race/timing. Given this failure is the result of a recent change causing the potential for the race, I don't think it will be all that helpful of a discovery tool to note the various exceptions/failures we have seen so far. https://gerrit.cloudera.org/#/c/16953/ http://gerrit.cloudera.org:8080/#/c/16968/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/16968/1/CMakeLists.txt@123 PS1, Line 123: kudu-subprocess > I'm a bit surprised that kudu-subprocess uses kudu-client mode. Is that so Yeah, I suppose kudu-proto is more accurate. I will fix it. http://gerrit.cloudera.org:8080/#/c/16968/1/CMakeLists.txt@123 PS1, Line 123: kudu-hms > nit: kudu-hive ? Done http://gerrit.cloudera.org:8080/#/c/16968/1/CMakeLists.txt@127 PS1, Line 127: add_custom_command(OUTPUT ${CLIENT_JAR} : COMMAND ./gradlew :kudu-client:jar ${GRADLE_FLAGS} : WORKING_DIRECTORY "${JAVA_DIR}" : DEPENDS init_gradle) > Just making sure I understand this correctly. The race is that kudu-subproc Yes your description is correct. For some reason I thought both modules used the client when initially building the patch. I adjusted it to use kudu-proto instead. -- To view, visit http://gerrit.cloudera.org:8080/16968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefa02e52a74f8a60c3029188995574ffdb0d3d5c Gerrit-Change-Number: 16968 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 25 Jan 2021 20:51:17 +0000 Gerrit-HasComments: Yes
