Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16974 )
Change subject: KUDU-2612: add a TxnSystemClient to the tservers ...................................................................... Patch Set 4: Code-Review+1 (5 comments) Looks good overall, just a few nits and one question. http://gerrit.cloudera.org:8080/#/c/16974/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16974/4//COMMIT_MSG@33 PS4, Line 33: I left a TODO to refactor for code reuse SGTM -- I guess we can address that later on when the rest of the related pieces are all in place. http://gerrit.cloudera.org:8080/#/c/16974/4/src/kudu/transactions/txn_system_client.cc File src/kudu/transactions/txn_system_client.cc: http://gerrit.cloudera.org:8080/#/c/16974/4/src/kudu/transactions/txn_system_client.cc@62 PS4, Line 62: disable_txn_system_client_init > Should it be tagged as hidden as well? Do you expect this to be used outsid I guess a flag tagged as 'unsafe' is automatically marked as 'hidden': https://github.com/apache/kudu/blob/202bcae7f12ca0d7ac43e0a07e57f3236c8f968d/src/kudu/util/flag_tags.h#L55-L59 http://gerrit.cloudera.org:8080/#/c/16974/4/src/kudu/transactions/txn_system_client.cc@404 PS4, Line 404: 1 nit: does it make sense to set it to be equal to the connection negotiation timeout? http://gerrit.cloudera.org:8080/#/c/16974/4/src/kudu/transactions/txn_system_client.cc@414 PS4, Line 414: s = TxnSystemClient::Create(master_addrs, &txn_client); nit: what if masters become unavailable right after the check above but before sending this request? I guess it's highly unlikely, but what do you think of introducing custom client builder settings for TxnSystemClient? Something like shorter 'administrative_timeout' setting? http://gerrit.cloudera.org:8080/#/c/16974/4/src/kudu/tserver/tablet_server.cc File src/kudu/tserver/tablet_server.cc: http://gerrit.cloudera.org:8080/#/c/16974/4/src/kudu/tserver/tablet_server.cc@107 PS4, Line 107: () nit: parenthesis are not necessary here -- To view, visit http://gerrit.cloudera.org:8080/16974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33b5a2bb5c56ae4bb4b42069af5813e2780fc4bc Gerrit-Change-Number: 16974 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Jan 2021 03:52:36 +0000 Gerrit-HasComments: Yes
