Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16956 )
Change subject: KUDU-3230: Fix the issue of hardcode sasl_proto_name ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/16956/16/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/16956/16/src/kudu/integration-tests/security-itest.cc@240 PS16, Line 240: //string klist; : //ASSERT_OK(cluster_->kdc()->Klist(&klist)); : //ASSERT_STR_CONTAINS(klist, spn); Could you remove this commented out code? http://gerrit.cloudera.org:8080/#/c/16956/16/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/16956/16/src/kudu/rpc/messenger.cc@64 PS16, Line 64: return v.find_first_of("\t\n ") == std::string::npos; More comprehensive to use isspace() check as it covers other whitespace characters as well. https://en.cppreference.com/w/cpp/string/byte/isspace -- To view, visit http://gerrit.cloudera.org:8080/16956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1c8f9d9f772d000d9a588e4e9d6028711a62915 Gerrit-Change-Number: 16956 Gerrit-PatchSet: 16 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Jan 2021 18:00:01 +0000 Gerrit-HasComments: Yes
