Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16956 )
Change subject: KUDU-3230: Fix the issue of hardcode sasl_proto_name ...................................................................... Patch Set 17: (2 comments) It seems the tests are still failing? http://gerrit.cloudera.org:8080/#/c/16956/17/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/16956/17/src/kudu/integration-tests/security-itest.cc@229 PS17, Line 229: test-admin Should this match current value of the FLAGS_sasl_krb5_principal_name ? http://gerrit.cloudera.org:8080/#/c/16956/17/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/16956/17/src/kudu/rpc/messenger.cc@59 PS17, Line 59: principal Is this supposed to accept full principal name here or it's supposed to be the primary part only? https://web.mit.edu/kerberos/krb5-1.5/krb5-1.5.4/doc/krb5-user/What-is-a-Kerberos-Principal_003f.html -- To view, visit http://gerrit.cloudera.org:8080/16956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1c8f9d9f772d000d9a588e4e9d6028711a62915 Gerrit-Change-Number: 16956 Gerrit-PatchSet: 17 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 10 Feb 2021 19:58:37 +0000 Gerrit-HasComments: Yes
