Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16984 )
Change subject: [docker] Update pip install ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh File docker/bootstrap-python-env.sh: http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh@37 PS1, Line 37: "7" > Would it make sense to fail if below 2.7 in an obvious way? I imagine it'll We could, though I haven't really made a habit of handling things we don't expect to happen at all in these scripts given all the base images we allow are guaranteed to have Python 2.7 or higher. For simplicity, I would rather not handle it. http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh@38 PS1, Line 38: c > nit: maybe mention that pypa's generic script isn't supported with 2.7 so w Done http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh@40 PS1, Line 40: Python 2. > nit: 2 and 3, as before? Done -- To view, visit http://gerrit.cloudera.org:8080/16984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 Gerrit-Change-Number: 16984 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Jan 2021 14:32:21 +0000 Gerrit-HasComments: Yes
