Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16984 )
Change subject: [docker] Update pip install ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh File docker/bootstrap-python-env.sh: http://gerrit.cloudera.org:8080/#/c/16984/1/docker/bootstrap-python-env.sh@37 PS1, Line 37: "7" > We could, though I haven't really made a habit of handling things we don't Yeah, I guess having explicit case for any unexpected version of python here would be nice, but if you know it's guaranteed not to happen, it would be just some never-used extra code. -- To view, visit http://gerrit.cloudera.org:8080/16984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a22e5084f8a5973d26372372f2ead4c46dcda9 Gerrit-Change-Number: 16984 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Jan 2021 17:10:59 +0000 Gerrit-HasComments: Yes
