Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16936 )
Change subject: [master] KUDU-2181 Raft ChangeConfig request to remove a master ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16936/2/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/16936/2/src/kudu/master/dynamic_multi_master-test.cc@952 PS2, Line 952: master_to_remove = cluster_->master(non_leader_master_idx)->uuid(); Bug: Should be leader_master_idx. http://gerrit.cloudera.org:8080/#/c/16936/2/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/16936/2/src/kudu/master/master.cc@526 PS2, Line 526: for (const auto& peer : config.peers()) { > We had a group discussion about whether to use UUIDs vs hostports. Summariz I'm addressing that discussion of using hostport and optional UUID in a subsequent patchset in the same review. -- To view, visit http://gerrit.cloudera.org:8080/16936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76c03b8850faef60b65f85184c0a4db7cc6759ee Gerrit-Change-Number: 16936 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 30 Jan 2021 02:22:47 +0000 Gerrit-HasComments: Yes
