Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16936 )
Change subject: [master] KUDU-2181 Raft ChangeConfig request to remove a master ...................................................................... Patch Set 7: Code-Review+2 (1 comment) It seems ExactlyOnceSemanticsITest.TestWritesWithExactlyOnceSemanticsWithCrashyNodes failed in ASAN build, but I don't think it's related: F0208 21:12:39.455036 24165 ts_itest-base.cc:579] Check failed: _s.ok() Bad status: Runtime error: /tmp/dist-test-taskutC4iI/build/asan/bin/kudu: process exited with non-zero status 1 http://gerrit.cloudera.org:8080/#/c/16936/6/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/16936/6/src/kudu/master/dynamic_multi_master-test.cc@1082 PS6, Line 1082: : // Empty HostPort. > RemoveMasterFromCluster() uses RunLeaderMasterRPC() which retries in case o Ah, indeed. Thank you for the clarification. -- To view, visit http://gerrit.cloudera.org:8080/16936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76c03b8850faef60b65f85184c0a4db7cc6759ee Gerrit-Change-Number: 16936 Gerrit-PatchSet: 7 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 08 Feb 2021 22:05:54 +0000 Gerrit-HasComments: Yes
