Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17046 )
Change subject: txns: syntactically sweeten some tuple-like variables ...................................................................... Patch Set 1: (1 comment) Thank you for updating the code to use the new C++17 feature. It seems lint isn't happy with new syntax: 23:34:19 /home/jenkins-slave/workspace/kudu-master/3/src/kudu/transactions/txn_status_manager.cc:843: Extra space before [ [whitespace/braces] [5] http://gerrit.cloudera.org:8080/#/c/17046/1/src/kudu/transactions/txn_status_manager.cc File src/kudu/transactions/txn_status_manager.cc: http://gerrit.cloudera.org:8080/#/c/17046/1/src/kudu/transactions/txn_status_manager.cc@843 PS1, Line 843: auto [map_iter, emplaced] = commits_in_flight_.emplace(txn_id, lint isn't happy with this: 23:34:19 /home/jenkins-slave/workspace/kudu-master/3/src/kudu/transactions/txn_status_manager.cc:843: Extra space before [ [whitespace/braces] [5] -- To view, visit http://gerrit.cloudera.org:8080/17046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice0add1d0c8487f97772732cffb463292efe8910 Gerrit-Change-Number: 17046 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 09 Feb 2021 08:22:56 +0000 Gerrit-HasComments: Yes
