Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17046 )
Change subject: txns: syntactically sweeten some tuple-like variables ...................................................................... txns: syntactically sweeten some tuple-like variables This uses the C++17 feature to use structured bindings[1] in a few places. To pass lint, this patch also pulls in a patch[2] merged into the cpplint project. Note that the Google Style Guide[3] does mention structured bindings, so they seem like fair game in Kudu's codebase. [1] https://en.cppreference.com/w/cpp/language/structured_binding [2] https://github.com/cpplint/cpplint/pull/126 [3] https://google.github.io/styleguide/cppguide.html#Type_deduction Change-Id: Ice0add1d0c8487f97772732cffb463292efe8910 Reviewed-on: http://gerrit.cloudera.org:8080/17046 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/transactions/txn_status_manager.cc M thirdparty/download-thirdparty.sh M thirdparty/patches/google-styleguide-cpplint.patch 3 files changed, 27 insertions(+), 20 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ice0add1d0c8487f97772732cffb463292efe8910 Gerrit-Change-Number: 17046 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
