Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17052 )
Change subject: [test] Fix InstanceDetectorTest.Timeout when run on AWS ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/17052/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17052/3//COMMIT_MSG@11 PS3, Line 11: the curl request returns in less time than that It seemed to me that's the case when it fails, no? http://gerrit.cloudera.org:8080/#/c/17052/3/src/kudu/util/cloud/instance_metadata.cc File src/kudu/util/cloud/instance_metadata.cc: http://gerrit.cloudera.org:8080/#/c/17052/3/src/kudu/util/cloud/instance_metadata.cc@106 PS3, Line 106: false Maybe, allow to specify the list of DNS servers "as is" to be supplied for the CURLOPT_DNS_SERVERS option for curl_easy_setopt()? That way it might be useful in other scenarios. http://gerrit.cloudera.org:8080/#/c/17052/3/src/kudu/util/curl_util.h File src/kudu/util/curl_util.h: http://gerrit.cloudera.org:8080/#/c/17052/3/src/kudu/util/curl_util.h@82 PS3, Line 82: set_dns_servers It would be great to add a few lines about the exact curl option under the hood (CURLOPT_DNS_SERVERS). -- To view, visit http://gerrit.cloudera.org:8080/17052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0880c2d8f94ae6208adfdd0e21eea91727469979 Gerrit-Change-Number: 17052 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 10 Feb 2021 00:30:00 +0000 Gerrit-HasComments: Yes
