Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17052 )
Change subject: [test] Fix InstanceDetectorTest.Timeout when run on AWS ...................................................................... [test] Fix InstanceDetectorTest.Timeout when run on AWS When running InstanceDetectorTest.Timeout on AWS the test frequently fails because even though a timeout of 1 ms is set, the curl request returns in less time than that. In order to reliably force a timeout regardless of where the test is run this patch configures the test to use bad DNS servers preventing a timely response. Example Failure: [ RUN ] InstanceDetectorTest.Timeout W0208 03:46:56.690357 4190 instance_detector.cc:116] could not retrieve GCE instance metadata: Network error: curl error: Couldn't resolve host name: Could not resolve host: metadata.google.internal W0208 03:46:56.690555 4191 instance_detector.cc:116] could not retrieve OpenStack instance metadata: Network error: curl error: HTTP response code said error: The requested URL returned error: 404 Not Found W0208 03:46:56.690815 4189 instance_detector.cc:116] could not retrieve Azure instance metadata: Network error: curl error: HTTP response code said error: The requested URL returned error: 404 Not Found /data0/somelongdirectorytoavoidrpathissues/src/kudu/src/kudu/util/cloud/instance_detector-test.cc:110: Failure Value of: s.IsNotFound() Actual: false Expected: true OK Change-Id: I0880c2d8f94ae6208adfdd0e21eea91727469979 Reviewed-on: http://gerrit.cloudera.org:8080/17052 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <aser...@cloudera.com> --- M src/kudu/util/cloud/instance_detector-test.cc M src/kudu/util/cloud/instance_metadata.cc M src/kudu/util/curl_util.cc M src/kudu/util/curl_util.h 4 files changed, 29 insertions(+), 0 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0880c2d8f94ae6208adfdd0e21eea91727469979 Gerrit-Change-Number: 17052 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
