Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17051 )
Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc File src/kudu/security/crypto-test.cc: http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc@99 PS2, Line 99: if (FIPS_mode()) { Nit: It'd be good to bump googletest version to 1.10 and use the GTEST_SKIP() macro that'll mark the test as SKIPPED instead of PASSED for FIPS till the test is fixed. https://github.com/google/googletest/pull/1544 Thirdparty is still building for me with following change... $ git diff diff --git a/thirdparty/vars.sh b/thirdparty/vars.sh index 6b8eab85f..ca034bd98 100644 --- a/thirdparty/vars.sh +++ b/thirdparty/vars.sh @@ -46,7 +46,7 @@ GLOG_VERSION=0.3.5 GLOG_NAME=glog-$GLOG_VERSION GLOG_SOURCE=$TP_SOURCE_DIR/$GLOG_NAME -GMOCK_VERSION=1.8.0 +GMOCK_VERSION=1.10.0 GMOCK_NAME=googletest-release-$GMOCK_VERSION GMOCK_SOURCE=$TP_SOURCE_DIR/$GMOCK_NAME -- To view, visit http://gerrit.cloudera.org:8080/17051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88 Gerrit-Change-Number: 17051 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 10 Feb 2021 00:47:04 +0000 Gerrit-HasComments: Yes
