Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17051 )
Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc File src/kudu/security/crypto-test.cc: http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc@98 PS2, Line 98: Skip when run in FIPS mode due to different private key format. nit: this comment looks like a comment explaining what's going on, but not TODO per se http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc@99 PS2, Line 99: if (FIPS_mode()) { > Nit: It'd be good to bump googletest version to 1.10 and use the GTEST_SKIP Good find! I think this deserves a separate changelist on its own. Ideally, there should be 2 changelists: * a changelist to bump GMOCK_VERSION from 1.8.0 to 1.10.0 * a changelist to replace all constructs like this and AllowSlowTests() -- To view, visit http://gerrit.cloudera.org:8080/17051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88 Gerrit-Change-Number: 17051 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 10 Feb 2021 00:54:40 +0000 Gerrit-HasComments: Yes
