Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16752 )
Change subject: tablet: allow interleaving of row liveness between compaction input rows ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/16752/6/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: http://gerrit.cloudera.org:8080/#/c/16752/6/src/kudu/integration-tests/fuzz-itest.cc@2044 PS6, Line 2044: TEST_INSERT_IGNORE nit: is it crucial to have INSERT_INGORE instead of INSERT here? Do you mind adding a comment in this regard? http://gerrit.cloudera.org:8080/#/c/16752/6/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/16752/6/src/kudu/tablet/compaction.cc@366 PS6, Line 366: AdvanceToLastInList(&right_last); Here and below: is AdvanceToLastInList really supposed to be under the #ifndef clause? Could you add a comment explaining the reasoning for adding this only for builds with builds where NDEBUG is not defined? -- To view, visit http://gerrit.cloudera.org:8080/16752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I042a7d70d32edf9d2a3a077790821893f162880a Gerrit-Change-Number: 16752 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 23 Feb 2021 05:02:00 +0000 Gerrit-HasComments: Yes
