Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16752 )
Change subject: tablet: allow interleaving of row liveness between compaction input rows ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/16752/6/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: http://gerrit.cloudera.org:8080/#/c/16752/6/src/kudu/integration-tests/fuzz-itest.cc@2044 PS6, Line 2044: F(FuzzTest, TestDo > nit: is it crucial to have INSERT_INGORE instead of INSERT here? Do you mi Most of these cases were found by random fuzzing, and I just happened to hit a crash with INSERT_IGNORE. INSERT works too, so I'll update it to be less conspicuous. http://gerrit.cloudera.org:8080/#/c/16752/6/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/16752/6/src/kudu/tablet/compaction.cc@366 PS6, Line 366: nst Mutation* right_last = right. > Here and below: is AdvanceToLastInList really supposed to be under the #ifn Yeah, it's only necessary for the DCHECK. If we're not running the validation, there's no point in iterating. http://gerrit.cloudera.org:8080/#/c/16752/8/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/16752/8/src/kudu/tablet/compaction.cc@369 PS8, Line 369: if (PREDICT_TRUE(FLAGS_dcheck_on_kudu_2233_invariants)) { > nit: if this validation is empty in NDEBUG case, maybe put the whole 'if()' Good point. Done -- To view, visit http://gerrit.cloudera.org:8080/16752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I042a7d70d32edf9d2a3a077790821893f162880a Gerrit-Change-Number: 16752 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 26 Feb 2021 00:59:48 +0000 Gerrit-HasComments: Yes
