Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17124 )
Change subject: [java] KUDU-3213: try at different server on TABLET_NOT_RUNNING ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17124/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/17124/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@96 PS4, Line 96: setRangePartitionColumns(Collections.singletonList("key")) nit: would it make sense to use hash partitioning instead? Otherwise, how do we know that the quiesce tablet server hosts the replica that contains the necessary data? If it's so even with range-partitioned table, it would be great if you could add a small comment explaining why it's so. Thanks! http://gerrit.cloudera.org:8080/#/c/17124/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@120 PS4, Line 120: if the scan goes to the quiescing server nit: how do we know it's so, indeed? Could it happen that the scanner always hits only non-quested servers? -- To view, visit http://gerrit.cloudera.org:8080/17124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38ac84a52676ff361fa1ba996665b338d1bbfba1 Gerrit-Change-Number: 17124 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 02 Mar 2021 02:52:22 +0000 Gerrit-HasComments: Yes
