Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17124 )
Change subject: [java] KUDU-3213: try at different server on TABLET_NOT_RUNNING ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/17124/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/17124/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@96 PS4, Line 96: set some partitioning though). > nit: would it make sense to use hash partitioning instead? Otherwise, how The partitioning isn't important here other than the fact that Kudu complains if there's none set. Added a comment. http://gerrit.cloudera.org:8080/#/c/17124/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@120 PS4, Line 120: rver.waitFor()); > nit: how do we know it's so, indeed? Could it happen that the scanner alwa We don't, and we might not. But without proper handling of quiescing servers, at least, without proper handling of quiescing this test fails a non-negligible amount of the time. -- To view, visit http://gerrit.cloudera.org:8080/17124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38ac84a52676ff361fa1ba996665b338d1bbfba1 Gerrit-Change-Number: 17124 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 02 Mar 2021 19:58:35 +0000 Gerrit-HasComments: Yes
