Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17156 )
Change subject: [gutil] use C++17's [[fallthrough]] attribute ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17156/1/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/17156/1/src/kudu/master/master_service.cc@845 PS1, Line 845: case MasterFeatures::RANGE_PARTITION_BOUNDS: [[fallthrough]]; > warning: switch has 2 consecutive identical branches [bugprone-branch-clone Hm, not sure what this is saying. For consecutive fallthroughs should there only be one [[fallthrough]]? -- To view, visit http://gerrit.cloudera.org:8080/17156 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd0532c0c6403f9bccfa59413a103d812633f4f6 Gerrit-Change-Number: 17156 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 08 Mar 2021 06:21:14 +0000 Gerrit-HasComments: Yes
