Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17156 )
Change subject: [gutil] use C++17's [[fallthrough]] attribute ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17156/1/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/17156/1/src/kudu/master/master_service.cc@845 PS1, Line 845: case MasterFeatures::RANGE_PARTITION_BOUNDS: [[fallthrough]]; > Hm, not sure what this is saying. For consecutive fallthroughs should there I'm not sure I understand what this warning points at. Per this doc https://en.cppreference.com/w/cpp/language/switch , it seems every empty label should be supplied with [[fallthrough]]: Compilers may issue warnings on fallthrough (reaching the next case label without a break) unless the attribute [[fallthrough]] appears immediately before the case label to indicate that the fallthrough is intentional. I'm going to ignore this warning from TidyBot. -- To view, visit http://gerrit.cloudera.org:8080/17156 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd0532c0c6403f9bccfa59413a103d812633f4f6 Gerrit-Change-Number: 17156 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 08 Mar 2021 06:43:25 +0000 Gerrit-HasComments: Yes
