Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17193 )
Change subject: [security] small re-factoring on TlsHandshake ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.h File src/kudu/security/tls_handshake.h: http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.h@166 PS3, Line 166: // Data which is left pending in the write BIO after the last call to : // Continue(), i.e. the data left pending after completing the TLS handshake. : std::string rbio_pending_data_; I might be missing something: is this used? http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.cc File src/kudu/security/tls_handshake.cc: http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.cc@94 PS3, Line 94: ssl_ = std::move(s); Not sure whether it'll make a functional difference, but would it make sense to only call this after both BIO_new() calls have succeeded? -- To view, visit http://gerrit.cloudera.org:8080/17193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e Gerrit-Change-Number: 17193 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 17 Mar 2021 22:59:03 +0000 Gerrit-HasComments: Yes
