Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17193 )
Change subject: [security] small re-factoring on TlsHandshake ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.h File src/kudu/security/tls_handshake.h: http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.h@166 PS3, Line 166: : } // namespace security : } // namespace kudu > I might be missing something: is this used? Whoops: it's not used, indeed. Good catch! It seems some extra stuff leaked from the follow-up patch :) http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.cc File src/kudu/security/tls_handshake.cc: http://gerrit.cloudera.org:8080/#/c/17193/3/src/kudu/security/tls_handshake.cc@94 PS3, Line 94: } > Not sure whether it'll make a functional difference, but would it make sens Well, at least it will be more consistent to allow for a retry calling Init() on the same object. Done. -- To view, visit http://gerrit.cloudera.org:8080/17193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8dfb16d0f59dc467d1d4dcdf5c1bc568062087e Gerrit-Change-Number: 17193 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 18 Mar 2021 01:15:31 +0000 Gerrit-HasComments: Yes
