Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17211 )
Change subject: [test] KUDU-3266 Fix flakiness in dynamic_multi_master test ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17211/2/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/17211/2/src/kudu/master/dynamic_multi_master-test.cc@602 PS2, Line 602: LOG(INFO) << Substitute("Pausing master $0, $1", master->uuid(), : master->bound_rpc_hostport().ToString()); > nit: if this was added for diagnostic purposes, maybe consider dropping thi I plan to drop this after a week or so once no flakiness has been observed due to this part of the verification. http://gerrit.cloudera.org:8080/#/c/17211/2/src/kudu/master/dynamic_multi_master-test.cc@607 PS2, Line 607: // We can run into table not found error in cases where the : // previously paused master that's leader of prior term resumes : // and the up to date follower doesn't become leader and the resumed : // master from previous term isn't up to date. See KUDU-3266 for details. : ASSERT_EVENTUALLY([&] { : NO_FATALS(cv.CheckRowCount(table_name, ClusterVerifier::EXACTLY, 0)); : }); > It might be interesting to explore different ways to ensure consistency at Thanks for that suggestion. I'll explore more into RYW mode for master operations. -- To view, visit http://gerrit.cloudera.org:8080/17211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifac1d95707064b6ac2624d3f52336d6c39afd3c8 Gerrit-Change-Number: 17211 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 23 Mar 2021 16:43:54 +0000 Gerrit-HasComments: Yes
