Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17211 )
Change subject: [test] KUDU-3266 Fix flakiness in dynamic_multi_master test ...................................................................... [test] KUDU-3266 Fix flakiness in dynamic_multi_master test Flakiness was reported in dynamic_multi_master test after the introduction of test for recovering dead master, commit 4b4a8c0f2f. See KUDU-3266 for the analysis. This change wraps the check for row count under ASSERT_EVENTUALLY to ensure the resumed master and the remaining master are given a chance to communicate Raft messages and become up to date. Tests: - Reproduced the issue with ASAN build with dist-test. - Verified no failures over 100 iterations with the fix on ASAN build. Change-Id: Ifac1d95707064b6ac2624d3f52336d6c39afd3c8 Reviewed-on: http://gerrit.cloudera.org:8080/17211 Tested-by: Bankim Bhavsar <[email protected]> Reviewed-by: Andrew Wong <[email protected]> Reviewed-by: Mahesh Reddy <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/master/dynamic_multi_master-test.cc 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Bankim Bhavsar: Verified Andrew Wong: Looks good to me, approved Mahesh Reddy: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/17211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifac1d95707064b6ac2624d3f52336d6c39afd3c8 Gerrit-Change-Number: 17211 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]>
